Bug in mnbrak.cpp (fixed in v. 2.11)

[Saul Teukolsky]

The line

shft3(bx,cx,u,cx+GOLD*(cx-bx));

should be

shft3(bx,cx,u,u+GOLD*(u-cx));

[simoncoggins]

Does this bug exist in the C version as well?

Should this line:

SHFT(*bx,*cx,u,*cx+GOLD*(*cx-*bx))

be this instead:

SHFT(*bx,*cx,u,u+GOLD*(u-*cx))

Thanks,

Simon

[Saul Teukolsky]

Hi Simon,

No, the C code is correct. The reason is that a macro works differently from a function call. In a macro, the current values of variables are used at each stage. In a function call, the arguments are each evaluated independently.

Regards,
Saul Teukolsky

[simoncoggins]

Ok, thanks very much.

Simon

[grzes]

I was wondering whether the bug somehow also applies to mnbrak for pascal, verison 1.3?

[Saul Teukolsky]

No, only in the C++ v 2.10.